Product Development in Brisbane

A Somewhat Questionable Pair of Commit Messages

Andrew recently mentioned that I'm working on E2 currently.  We dog food all our products, and automatically deploy updates to our internal systems.  While doing some work on E2 I discovered that it isn't currently automatically updating.  In troubleshooting this I noticed that the line saying to do this was commented out.  The svn log had the following messages:

commit xxx: ADDED: Automatic deployment for E2
commit xxx+1: REMOVED: Automatic deployment for E2

Less than fully helpful when trying to work out why the automatic deployment was removed.

5 Responses to “A Somewhat Questionable Pair of Commit Messages”

  1. Adrian Sutton Says:

    If you redeploy a webapp in Tomcat too many times, Tomcat dies with an out of memory exception due to the PermGen space running out. Since that kills Tomcat it’s generally better to manually deploy new builds and check it’s still running instead of automatically killing Tomcat every 5-10 commits.

    An added complication is that the deployment is done by a webapp running in the same Tomcat instance, so you can’t just restart Tomcat.

  2. robert Says:

    yep — which is why the following two commit messages appeared:
    ADDED: Autodeploy of E2. E2 should be autodeployed on every build, because we want to be dogfooding the latest and greatest version.
    REMOVED: E2Wiki isn’t deployed. Deploying it preiodically kills tomcat.

    and a comment in the config.xml ;)

  3. Adrian Sutton Says:

    heh. You can and should manually deploy it from time to time via the autodeployer though. At some point I’ll find a way to make it all work - probably with a nightly deploy then restart cron job.

  4. robert Says:

    hmm… the conversations one has online when people are away on leave ;)….

    Have you been using the office webcam to see the conversations we have been having about this? That’s the same conclusion we came to.

  5. Adrian Sutton Says:

    I’ve just been so vocal there for so long that everyone knows what I’d do without me needing to be there. :) You can run the autodeployer ant tasks directly instead of going through the webapp without too much trouble, that’ll solve the asynchronous deployment problem - just make sure you run it as the right user or things will get screwy.

Leave a Reply